fix: made search bar visible on mobile #1597
Conversation
manavsiddharthgupta
requested review from
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
manavsiddharthgupta
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1597--asyncapi-website.netlify.app/ |
manavsiddharthgupta
force-pushed
the
manavsidd/searchbar-visibility
branch
from
e77972e to
ca2e3d9
Compare
|
@manavsiddharthgupta We follow Conventional Commits specification |
manavsiddharthgupta
changed the title
Just updated |
|
|
Could you please provide me with the steps to reproduce the bug you reported? I've tried but haven't been able to replicate it. |
|
Just open the preview on your browser ,you will see it then. |
|
The preview version looks good to me, please let me know if I am missing something |
|
Not on mobile view,see it on desktop view |
|
I think that might be a deploy error of that time.It is good now |
|
@sambhavgupta0705 who is going to review the pr? |
|
@akshatnema can you review the code and merge my pr |
There was a problem hiding this comment.
@manavsiddharthgupta Thanks for creating the PR. Please make sure you don't make unnecessary formatting inside the PR because it finds it difficult for the maintainers to review the PR with unnecessary changes in it.
|
/rtm |
Description
Related issue(s)
Resolves #1595